Fix hover on method parameters with inline RBS annotations#369
Merged
mame merged 3 commits intoruby:masterfrom Feb 17, 2026
Merged
Fix hover on method parameters with inline RBS annotations#369mame merged 3 commits intoruby:masterfrom
mame merged 3 commits intoruby:masterfrom
Conversation
Contributor
Author
|
screenshot :) before after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue where hovering was not possible when method arguments had rbs comments.
The root cause was an off-by-one error:
Prism::Location#start_lineis 1-based, butrbs_commentsis indexed by 0-based line numbers.As a result, the first element of
rbs_commentsended up beingnil, e.g.:whtsht@0e6baab
This PR fixes the issue by subtracting 1 from
start_linebefore indexing/storing intorbs_comments.